Best electric brass & guitar songbooks according to redditors

Two come to mind. If you're looking for more jazz oriented stuff then Charlie Parker's Omnibook is a good place. Something a little different but one of my favorites is an etude book by John Patitucci.

I recieved a tab book for my birthday two years ago for my birthday. It was the Metallica Riff by Riff book. It advertises itself to include all the "essential" riffs for each song, but what you get is a very limited version of what I believe the book should be. The book had some cool stuff like a timeline of the band, descriptions of how to read the tabs, and what gear they use. Each song was given 2 pages of space. Nothing wrong with that, as there are obviously constraints when you are trying to cram a band's entire song list into one book. However, instead of each song getting two pages jam-packed with riffs, You get a stupid little description at the top of each riff (which doesn't really contribute except when it tells you what tuning something is in) and each riff interspersed with just as much empty space as there is space dedicated to the tabs. Sometimes that just cut it short and dedicate the last third of the page to a picture of the band.

TL;DR: Bought a Metallica tab book that claimed to have "every essential riff" but was not the case at all. In two pages there tended to be around 6 lines of actual tabs, with the rest of the space wasted on useless text, pictures, and just plain blank space.

Here it is on Amazon.